[tarantool-patches] Re: [PATCH] lib/core/fiber: Initialize stack_watermark where appropriate

[Konstantin Osipov]

* Cyrill Gorcunov <gorcunov at gmail.com> [19/03/18 22:20]:
> On Mon, Mar 18, 2019 at 10:10:08PM +0300, Konstantin Osipov wrote:
> > > 
> > > Even 8 elements are not guarantee us from false positives and
> > > with a sole element the situation would be even worse.
> > 
> > Well, then let's increase the number of elements to 32 or 64, or,
> > better yet, 128, to make the situation better.
> > 
> > Why did you guys choose 8?
> 
> To cover low 1024 bytes. Maximal path is about 4K limit
> so I think in average ~1/4 of page should catch paths
> on stack.

Okay, well, that at least a plausible cause, I guess I'd be nice to
see it in the comment for the poison array. However, you could use
4 integers and a larger poison offset?-))

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov