[tarantool-patches] Re: [PATCH 3/6] vinyl: cache iterator: consolidate curr_stmt updates

[Konstantin Osipov]

* Vladimir Davydov <vdavydov.dev at gmail.com> [19/03/26 18:56]:
> Currently, vy_cache_iterator->curr_stmt is updated by top-level iterator
> functions - next, skip, restore - which results in code duplication and
> spreads core logic among multiple places. To reduce the amount of code
> and make it generally easier to follow, this patch moves the updates to
> low level functions - step, seek. It also makes the seek method return
> the stop flag, which makes it similar to step, thus making the code more
> consistent.

OK to push. As a nit, I would pass stop as an out parameter, not
in return value. We may want to use the return value to indicate
an error sometime.


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov