[tarantool-patches] Re: [PATCH] lib/core/fiber: Initialize stack_watermark where appropriate

[Konstantin Osipov]

* Vladimir Davydov <vdavydov.dev at gmail.com> [19/03/18 20:56]:

> On Mon, Mar 18, 2019 at 08:23:52PM +0300, Cyrill Gorcunov wrote:
> > The stack_watermark member declared with HAVE_MADV_DONTNEED wrap,
> > so need to guard it here the same way.

What is the reason to keep the poison pool 8 elements now that it
is only used to save on madvise() invocations and is put in a
random position? Shouldn't 1 element be enough? 

What is the actual stack size for 99.9% of cases? Why not put the
poison at 16kb of stack?  

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov