[tarantool-patches] Re: [PATCH 0/3] Make LIKE accept only arguments of type TEXT

[Vladislav Shpilevoy]

LGTM.

On 09/03/2019 19:59, Nikita Pettik wrote:
> First two patches simply remove unnecessary macro and code connected
> with it. Third one - disallows arguments of LIKE be of different
> from text-like types.
> 
> Branch: https://github.com/tarantool/tarantool/tree/np/gh-3954-disallow-blob-in-like
> Issue: https://github.com/tarantool/tarantool/issues/3954
> 
> Nikita Pettik (3):
>    sql: remove SQL_LIKE_DOESNT_MATCH_BLOBS
>    sql: remove sql_like_count global counter
>    sql: make LIKE accept only TEXT arguments
> 
>   src/box/sql/func.c            | 34 +++++++++-----------
>   src/box/sql/sqlInt.h          |  2 --
>   src/box/sql/vdbe.c            | 14 +--------
>   src/box/sql/vdbeInt.h         |  6 ++++
>   src/box/sql/where.c           |  8 -----
>   src/box/sql/whereInt.h        |  4 ---
>   src/box/sql/wherecode.c       | 73 -------------------------------------------
>   test/sql-tap/tkt1537.test.lua |  4 +--
>   test/sql/types.result         | 45 ++++++++++++++++++++++++++
>   test/sql/types.test.lua       | 15 +++++++++
>   10 files changed, 84 insertions(+), 121 deletions(-)
> 
> -- 
> 2.15.1
> 
>