[tarantool-patches] Re: [PATCH 3/3] Transaction support for applier

[Konstantin Osipov]

* Georgy Kirichenko <georgy at tarantool.org> [19/03/03 23:30]:
> diff --git a/src/box/txn.c b/src/box/txn.c
> index 7900fb3ab..f6bf72d0c 100644
> --- a/src/box/txn.c
> +++ b/src/box/txn.c
> @@ -34,6 +34,7 @@
>  #include "journal.h"
>  #include <fiber.h>
>  #include "xrow.h"
> +#include "replication.h"

What do you need this header for? instance_id? Is there a way to
keep these two modules independent on each other? 

> +	txn->n_remote_rows = 0;

Just the same as in the previous patch, this name is very general.
Could you please come up with something more specific?

> +	/**
> +	 * Count of rows generated on a remote replica.
> +	 */
> +	int n_remote_rows;

OK, now I know what this is, although I don't know what is
"generated", but what is this for? Please write a better comment.


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov