[tarantool-patches] Re: [PATCH] sql: LIKE/LENGTH process '\0'
i.koptelov
ivan.koptelov at tarantool.org
Mon Mar 4 14:59:33 MSK 2019
> On 26 Feb 2019, at 23:16, Vladislav Shpilevoy <v.shpilevoy at tarantool.org> wrote:
>
>
>
> On 26/02/2019 21:44, i.koptelov wrote:
>>> On 26 Feb 2019, at 20:50, n.pettik <korablev at tarantool.org> wrote:
>>>
>>> Won’t bother you with portion of minor comments.
>>> I’ve pushed them, take a look. If they are OK, just
>>> squash (but don’t squash last commit) them and
>>> patch will be OK as well.
>>>
>>> Also, I’ve fixed a bit commit message. Add please
>>> doc request which includes user-visible changes.
>> Thank you for the fixes! They are OK for me.
>> Squashed them. Added doc request into the
>> commit message.
>
> If under a doc request you mean that: https://github.com/tarantool/tarantool/commit/4704f531fc4af0e074410c552a4f3a9d9848c949 then it is incorrect. Please, look at
> tarantool/docbot for the proper syntax, and check your requests in the online
> table: https://tarantool-docbot.herokuapp.com
>
> If you do not see your request here, then it is incorrect.
>
Thank you, I’ve changed the commit message. Now I can see my
doc request in the online table.
More information about the Tarantool-patches
mailing list