[tarantool-patches] Re: [PATCH 2/3] Merge apply row and apply_initial_join_row

[Konstantin Osipov]

* Georgy Kirichenko <georgy at tarantool.org> [19/03/03 23:30]:
> +/**
> + * Memtx engine instance
> + */
> +static struct memtx_engine *memtx = NULL;
> +/**
> + * Vinyl engine instance
> + */
> +static struct vinyl_engine *vinyl = NULL;

Would you have an instance for each engine? 

The idea with find_by_name() was that sometime in the future we
will have storage engines entirely pluggable (no, this will not
happen really).

So I'm OK with ditching engine_by_name, but then the declaration
should be in memtx_engine.h and vinyl_engine.h, respectively, or
at least in engine.h, not in box.[hc]

Re the patch itself, it's OK to push (I assume it helps moving
apply_row into applier).

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov