[tarantool-patches] Re: [PATCH 2/2] schema: add exact field count to SQL stat spaces

[Vladislav Shpilevoy]

On 21/03/2019 18:22, n.pettik wrote:
> 
> 
>> On 21 Mar 2019, at 16:31, Vladislav Shpilevoy <v.shpilevoy at tarantool.org> wrote:
>>
>> On that branch tests sql-tap/gh2548-select-compound-limit.test.lua
>> and sql-tap/gh2250-trigger-chain-limit.test.lua fail.
> 
> Are you sure? Travis is green; on my local machine both
> release and debug builds pass these tests as well (memtx
> and vinyl cases). Could you check it again, or provide more
> details concerning fails?

Hmm, I do not know, what it was, but now they pass :)

LGTM.

> 
>> On 19/03/2019 02:51, Nikita Pettik wrote:
>>> As a rule, system spaces don't feature exact field count. There is a
>>> reason for that: almost all of them have on replace triggers, which
>>> extract data from tuple and verify it. However, _sql_stat1 and
>>> _sql_stat4 spaces containing SQL specific statistics don't have such
>>> triggers. Hence, one can insert tuple to this space with greater number
>>> of fields, than format says. To prevent this, let's explicitly set exact
>>> field count to number of fields in format.
>>> ---
>>>   src/box/bootstrap.snap       | Bin 1831 -> 1840 bytes
>>>   src/box/lua/upgrade.lua      |  29 ++++++++++++++++++++++++++++-
>>>   test/box-py/bootstrap.result |   6 +++---
>>>   test/box/access_misc.result  |   4 ++--
>>>   test/sql/upgrade.result      |  39 +++++++++++++++++++++++++++++++++++++--
>>>   test/sql/upgrade.test.lua    |  13 +++++++++++++
>>>   6 files changed, 83 insertions(+), 8 deletions(-)
>