[tarantool-patches] Re: [PATCH v3 6/9] sql: rework six syntax errors

[Konstantin Osipov]

* imeevma at tarantool.org <imeevma at tarantool.org> [19/03/03 23:25]:
> This patch rewords six more syntax errors.
> 
> Part of #3965
> ---
>  src/box/errcode.h             |  3 +++
>  src/box/sql/build.c           |  4 +--
>  src/box/sql/resolve.c         | 62 +++++++++++++++++++++----------------------
>  test/box/misc.result          |  3 +++
>  test/sql-tap/check.test.lua   |  2 +-
>  test/sql-tap/colname.test.lua |  2 +-
>  6 files changed, 40 insertions(+), 36 deletions(-)

Please avoid adding a verb into error parameter and use singular:

"Subqueries are" + "prohibited in ..." -> "A subquery" + "is
prohibited in ..."

Otherwise OK to push.


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov