[tarantool-patches] [PATCH 3/4] vinyl: abort affected transactions when space is removed from cache

Георгий Кириченко georgy at tarantool.org
Mon Mar 25 11:57:07 MSK 2019


On Monday, March 25, 2019 11:17:43 AM MSK you wrote:
> On Mon, Mar 25, 2019 at 08:26:25AM +0300, Георгий Кириченко wrote:
> > I definitely dislike introducing a new callback, there are already a lot
> > of
> > dependencies. Also I'm afraid that this could prevent us from the
> > transactional ddl implementation.
> 
> I don't see a way to fix this issue without introducing a new callback.
> And frankly I don't quite understand your concern. If the new callback
> proves to be useless / harmful for transaction DDL, we will remove it -
> after all engine API isn't carved in stone.
But leads to increase in amount of work we should be done to implement in 
future. And we already have a space destroy callback.
> 
> > We have a space vtab and destroy, why shouldn't we use them?
> 
> Because the space becomes invalid before it gets destroyed - ALTER moves
> indexes to the new space before writing to WAL.
So it might be a high time to change it.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20190325/10c5b87f/attachment.sig>


More information about the Tarantool-patches mailing list