[tarantool-patches] [PATCH v3 5/5] Raise an error if remote transaction produces non-local changes

Vladimir Davydov vdavydov.dev at gmail.com
Wed Mar 27 15:06:59 MSK 2019


On Fri, Mar 22, 2019 at 03:06:10PM +0300, Georgy Kirichenko wrote:
> diff --git a/test/replication/on_replace.result b/test/replication/on_replace.result
> index 2e95b90ea..a02b90f7e 100644
> --- a/test/replication/on_replace.result
> +++ b/test/replication/on_replace.result
> @@ -154,20 +154,27 @@ box.space.s1:replace({1, 2, 3, 4})
>  ---
>  - [1, 2, 3, 4]
>  ...
> -while #(box.space.s2:select()) == 0 do fiber.sleep(0.00001) end
> +while (box.info.replication[3 - box.info.id].downstream.status ~= 'stopped') do fiber.sleep(0.00001) end

Nit:

3 - box.info.id ?

Looks confusing. Why not simply use 1? It should point to the master,
shouldn't it?

Other than that, the patch looks good to me.



More information about the Tarantool-patches mailing list