[PATCH 3/3] core/fiber: Put watermarks into stack to track its usage

Vladimir Davydov vdavydov.dev at gmail.com
Thu Mar 7 12:20:04 MSK 2019


On Thu, Mar 07, 2019 at 12:04:39PM +0300, Cyrill Gorcunov wrote:
> On Thu, Mar 07, 2019 at 11:27:58AM +0300, Vladimir Davydov wrote:
> ...
> > 
> > You can track the ratio of fibers that have overwritten the watermark
> > recently. If the ratio gets too high (say 90% out of 1000 recently
> > scheduled fibers), the minimal stack allocation should be increased.
> 
> IOW, we need to gather statistics :/ I would rather splt this task
> into two:
> 
>  - make stack 1M by default and madvise as not needed and merge,
>    it upstream asap, to not block users
> 
>  - second series is to optimize stack usage

Fair enough.



More information about the Tarantool-patches mailing list