[tarantool-patches] Re: [PATCH 2/2] net.box: fetch '_vcollation' sysview into the module

[Roman Khabibov]

> On Jun 5, 2019, at 8:28 PM, Vladimir Davydov <vdavydov.dev at gmail.com> wrote:
> 
> On Wed, Jun 05, 2019 at 08:08:39PM +0300, Roman Khabibov wrote:
>> 
>>> On Jun 4, 2019, at 7:36 PM, Vladimir Davydov <vdavydov.dev at gmail.com> wrote:
>>> 
>>> On Thu, May 30, 2019 at 03:36:03PM +0300, Roman Khabibov wrote:
>>>> Fetch "_vcollation" sysview to show collation name instead collation id.
>>>> 
>>>> Closes #3941
>>>> ---
>>>> src/box/lua/net_box.lua  | 24 ++++++++++++++++++------
>>>> test/box/net.box.result  |  2 +-
>>>> test/box/stat_net.result |  4 ++--
>>>> 3 files changed, 21 insertions(+), 9 deletions(-)
>>> 
>>> This one looks good to me, but you probably need to write a doc bot
>>> request.
>>> 
>> What should I write in this request? I understood, that you meant
>> info about _vcollation existance.
> 
> Yep, something like this I suppose:
> 
>  https://www.tarantool.io/en/doc/2.1/book/box/box_space/#box-space-vspace
> 
> BTW we miss _vsequence documentation. Should be added as well.
_vfunc too?