[tarantool-patches] [PATCH v3 06/14] txn: get rid of fiber_gc from txn_rollback

Vladimir Davydov vdavydov.dev at gmail.com
Fri Jun 14 12:21:14 MSK 2019


On Thu, Jun 13, 2019 at 10:28:24PM +0300, Георгий Кириченко wrote:
> On Thursday, June 13, 2019 5:12:56 PM MSK Vladimir Davydov wrote:
> > On Sun, Jun 09, 2019 at 11:44:35PM +0300, Georgy Kirichenko wrote:
> > > Don't touch a fiber gc storage on a transaction rollback explicitly.
> ...
> > 
> > As I wrote earlier, I'm pretty convinced we don't need to call
> > fiber_gc() after txn_commit/rollback at all. Please consider
> > removing it in a separate patch.
> I call fiber_gc in such cases only in order to preserve the previous behavior. 
> I think we could remove fiber_gc when all transaction data would be placed onto 
> transaction memory. We could talk about f2f

Discussed f2f. Agreed to try to remove fiber_gc() calls after
txn_commit/rollback() first.



More information about the Tarantool-patches mailing list