[tarantool-patches] Re: [PATCH v1 15/28] sql: remove SQL_SCHEMA errcode

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Fri Jun 14 01:24:57 MSK 2019


Thanks for the patch!

Consider my review fix below and on the branch
in a separate commit.

======================================================

diff --git a/src/box/sql/prepare.c b/src/box/sql/prepare.c
index 827828a1a..d909c8bf1 100644
--- a/src/box/sql/prepare.c
+++ b/src/box/sql/prepare.c
@@ -209,7 +209,7 @@ sqlReprepare(Vdbe * p)
 /*
  * Two versions of the official API.  Legacy and new use.  In the legacy
  * version, the original SQL text is not saved in the prepared statement
- * and so if a schema change occurs, SQL_SCHEMA is returned by
+ * and so if a schema change occurs, an error is returned by
  * sql_step().  In the new version, the original SQL text is retained
  * and the statement is automatically recompiled if an schema change
  * occurs.




More information about the Tarantool-patches mailing list