[tarantool-patches] Re: [PATCH 09/10] key_def: pass alloc callback to key_def_dump_parts

Vladimir Davydov vdavydov.dev at gmail.com
Mon Jun 10 18:28:21 MSK 2019


On Sat, Jun 01, 2019 at 11:41:42AM +0300, Konstantin Osipov wrote:
> * Konstantin Osipov <kostja at tarantool.org> [19/05/18 21:56]:
> > * Vladimir Davydov <vdavydov.dev at gmail.com> [19/05/17 17:54]:
> > > So that we can use an allocator different from the region in vylog.
> > 
> > Please, let's simply always use malloc.
> > 
> > btw, sql code is shit. not a single comment for entire call trace
> > of key_def_dump_parts() from there. I failed to understand whether
> > this is a hot path or not.
> 
> I stand by this request.

Please take a look at my reply I sent you earlier. Quoting it here:

} I did it this way so as to use lsregion for allocating vylog records in
} the next patch. Are you suggesting to use malloc() instead? I guess
} that's possible and that'd simplify things quite a bit. I just wanted to
} use lock-free allocator for this. Not sure if it's really necessary
} though, because vy_log_tx_write isn't a hot path.

https://www.freelists.org/post/tarantool-patches/PATCH-0910-key-def-pass-alloc-callback-to-key-def-dump-parts,2



More information about the Tarantool-patches mailing list