[tarantool-patches] Re: [PATCH 04/10] vinyl: rework vylog transaction backlog implementation

Vladimir Davydov vdavydov.dev at gmail.com
Thu Jun 6 14:58:05 MSK 2019


On Sat, Jun 01, 2019 at 11:38:38AM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev at gmail.com> [19/05/17 17:54]:
> 
> I like this approach, I would push it regardless of other patches.
> The patch is LGTM.

I'm afraid I can't push it without the previous patch. You see, I need
to flush the xlog buffer before loading vylog. I can't call xlog_flush
from vy_recovery_new unless it's running in the same thread as vylog
writer, because xlog struct shouldn't be used from different threads.
But without the previous patch vy_recovery_new runs in coio, not WAL.



More information about the Tarantool-patches mailing list