[tarantool-patches] Re: [RFC] box/lua/console: Add console.fmt module

Cyrill Gorcunov gorcunov at gmail.com
Fri Jun 21 15:41:30 MSK 2019


On Fri, Jun 21, 2019 at 03:14:12PM +0300, Konstantin Osipov wrote:
> 
> I don't care much about the internals here, but about the
> consistency of the console api:
> https://www.tarantool.io/en/doc/1.10/reference/reference_lua/console/

Well, I don't mind extending console api instead just need to figure
out how to put the engine into separate file (serisouly, console.lua
is already big enough).

> 
> I don't see why we can't fork serpent. But OK, provided you don't
> want serpent, what can serpent do that we're going to miss in an
> own implementation? Could you write down a summary so that we can
> analyze this ahead of time?

I will write the summary, but most important part is that they are
fetching dependency and code bloats like hell even if we don't need
most of the parts of serpent/pretty-print (initially I started with
serpent, integrated it into our code but didn't like the results much,
then I merged pretty-print engine, and again found that we need own
extensions for symbols like box.NULL which lead me to the conclusion
that if we can't use vanilla code then there is no much point to carry
these projects in our repo, better to stick small and simple functions
and extend them with time if we have to).




More information about the Tarantool-patches mailing list