[tarantool-patches] Re: [PATCH 1/1] test: fix unit/crypto test flakiness

Alexander Turenko alexander.turenko at tarantool.org
Sun Jun 23 21:37:52 MSK 2019


Looks good for me.

WBR, Alexander Turenko.

On Sun, Jun 23, 2019 at 08:17:30PM +0200, Vladislav Shpilevoy wrote:
> One of subtests was checking if crypto_decode returns an error
> when fails to decode. But due to randomness of the test sometimes
> it happened, that initial vector of encrypted data somehow didn't
> lead to an error. Decryption was not correct, but only in terms
> of result, not in terms of decryption algorithm. -1 was not
> returned, and diag was not set.
> 
> This patch checks all the cases.
> 
> Closes #4306
> ---
> Branch: https://github.com/tarantool/tarantool/tree/gerold103/gh-4306-flaky-unit-crypto
> Issue: https://github.com/tarantool/tarantool/issues/4306
> 
> [CC += Georgy] because he is an author of crypto module.
> [CC += Alexander] because he is an author of the issue, and revolves around
> tests.




More information about the Tarantool-patches mailing list