[tarantool-patches] Re: [PATCH v1 1/1] sql: move space existence check to VDBE

Kirill Yukhin kyukhin at tarantool.org
Thu Jun 6 17:07:46 MSK 2019


Hello,

On 08 May 20:02, imeevma at tarantool.org wrote:
> Before this patch, the existence of space was checked for the
> CREATE TABLE or CREATE VIEW statements during the parsing. If the
> space already exists, an error has been set and cleanup is
> performed. But, if the statement contained 'IF NOT EXIST', the
> cleanup was performed, but the error was not set. This causes an
> error when creating a foreign key during space creation.
> 
> This patch moves this check to VDBE. Thus, the parsing should now
> be properly closed before performing this check.
> 
> Closes #4196
> ---
> https://github.com/tarantool/tarantool/issues/4196
> https://github.com/tarantool/tarantool/tree/imeevma/gh-4196-move-space-existence-check-to-vdbe

I've checked your patch into 2.1 and master.

--
Regards, Kirill Yukhin




More information about the Tarantool-patches mailing list