[tarantool-patches] Re: [RFC] box/lua/console: Add console.fmt module

Cyrill Gorcunov gorcunov at gmail.com
Fri Jun 21 23:07:07 MSK 2019


On Fri, Jun 21, 2019 at 03:14:12PM +0300, Konstantin Osipov wrote:
> > so we simply can't use unmodified third party engines thus
> > better to keep own much simpler (hopefully) engine.
> 
> I don't see why we can't fork serpent. But OK, provided you don't
> want serpent, what can serpent do that we're going to miss in an
> own implementation? Could you write down a summary so that we can
> analyze this ahead of time?

To be precise my complains against serpent is only one: we will
need to patch it on top to handle special symbols from "box"
(as mentioned in the original github issue box.NULL). Note that
the seializer I provided are mostly taken from Konstantin's
draft patch (see https://github.com/tarantool/tarantool/issues/3834)
which in turn is derived from
https://github.com/stevedonovan/Penlight/blob/master/lua/pl/pretty.lua
i guess.

I think currently we don't support "block" mode (or as serpent names
it -- multiline output). For simple examples of output serpent provides
same data as our console.fmt code but I think the devil in details which
I didn't discover yet.

Thus if you're _quite_ sure that we better should use serpent then I'll
try to prepare new version and we will see how it looks.




More information about the Tarantool-patches mailing list