[tarantool-patches] Re: [PATCH v5 5/6] box: run check constraint tests on space alter

[Vladislav Shpilevoy]

Thanks for the fixes! See review fixes on the branch, and
at the end of the email. They are quite obvious.

==================================================================

diff --git a/src/box/alter.cc b/src/box/alter.cc
index 666ec3e6f..b0f8a8c9b 100644
--- a/src/box/alter.cc
+++ b/src/box/alter.cc
@@ -4356,7 +4356,8 @@ on_replace_dd_ck_constraint(struct trigger * /* trigger*/, void *event)
 			diag_raise();
 		ck_def_guard.is_active = false;
 		auto ck_guard = make_scoped_guard([=] {
-			ck_constraint_delete(new_ck_constraint); });
+			ck_constraint_delete(new_ck_constraint);
+		});
 		const char *name = new_ck_constraint->def->name;
 		struct ck_constraint *old_ck_constraint =
 			space_ck_constraint_by_name(space, name, strlen(name));
diff --git a/src/box/ck_constraint.c b/src/box/ck_constraint.c
index 2adbb3742..543c8b388 100644
--- a/src/box/ck_constraint.c
+++ b/src/box/ck_constraint.c
@@ -101,7 +101,7 @@ ck_constraint_resolve_field_names(struct Expr *expr,
  *                          an error description.
  * @param expr Ck constraint expression AST built for a given
  *             @a ck_constraint_def, see for (sql_expr_compile and
- *              ck_constraint_resolve_space_def) implementation.
+ *             ck_constraint_resolve_space_def) implementation.
  * @param space_def The space definition of the space this check
  *                  constraint is constructed for.
  * @retval not NULL sql_stmt program pointer on success.