[tarantool-patches] Re: [PATCH v1 18/28] sql: remove SQL_CONSTRAINT errcode

[Vladislav Shpilevoy]

Hi! Thanks for the patch!

On 15/06/2019 12:00, Mergen Imeev wrote:
> On Fri, Jun 14, 2019 at 12:24:55AM +0200, Vladislav Shpilevoy wrote:
>> Thanks for the patch!
>>
>> I've found 'sql_CONSTRAINT_UNIQUE' in sql-tap/unique.test.lua

It is still here. Please, fix.

>> on line 229. These tests are disabled by 'if 0 > 0', but another
>> comment says, that the issue #2495 fix should have enabled them
>> back. We need to either resurrect these tests, or drop them.
>>
>> Consider my review fixes below and on the branch
>> in a separate commit.
>>