[tarantool-patches] [PATCH v3 02/14] ddl: synchronize privileges cache with actual data state.
Vladimir Davydov
vdavydov.dev at gmail.com
Tue Jun 11 16:13:56 MSK 2019
On Sun, Jun 09, 2019 at 11:44:31PM +0300, Georgy Kirichenko wrote:
> We tend to synchronize cached data with the actual data changes: apply
> while on_replace and undo while on_rollback.
> ---
> src/box/alter.cc | 37 ++++++++++++++++---------------------
> 1 file changed, 16 insertions(+), 21 deletions(-)
>
> diff --git a/src/box/alter.cc b/src/box/alter.cc
> index ed9e55907..c4a1c52a9 100644
> --- a/src/box/alter.cc
> +++ b/src/box/alter.cc
> @@ -2938,31 +2938,23 @@ grant_or_revoke(struct priv_def *priv)
>
> /** A trigger called on rollback of grant, or on commit of revoke. */
> static void
> -revoke_priv(struct trigger * /* trigger */, void *event)
> +revoke_priv(struct trigger *trigger, void *event)
> {
> - struct txn *txn = (struct txn *) event;
> - struct txn_stmt *stmt = txn_last_stmt(txn);
> - struct tuple *tuple = (stmt->new_tuple ?
> - stmt->new_tuple : stmt->old_tuple);
> + (void) event;
> + struct tuple *tuple = (struct tuple *)trigger->data;
> struct priv_def priv;
> priv_def_create_from_tuple(&priv, tuple);
> - /*
> - * Access to the object has been removed altogether so
> - * there should be no grants at all. If only some grants
> - * were removed, modify_priv trigger would have been
> - * invoked.
> - */
> priv.access = 0;
> grant_or_revoke(&priv);
> }
>
> /** A trigger called on rollback of grant, or on commit of revoke. */
> static void
> -modify_priv(struct trigger * /* trigger */, void *event)
> +modify_priv(struct trigger *trigger, void *event)
> {
> - struct txn_stmt *stmt = txn_last_stmt((struct txn *) event);
> + (void) event;
> struct priv_def priv;
> - priv_def_create_from_tuple(&priv, stmt->new_tuple);
> + priv_def_create_from_tuple(&priv, (struct tuple *)trigger->data);
> grant_or_revoke(&priv);
> }
>
> @@ -2985,21 +2977,24 @@ on_replace_dd_priv(struct trigger * /* trigger */, void *event)
> priv_def_check(&priv, PRIV_GRANT);
> grant_or_revoke(&priv);
> struct trigger *on_rollback =
> - txn_alter_trigger_new(revoke_priv, NULL);
> + txn_alter_trigger_new(revoke_priv, new_tuple);
> txn_on_rollback(txn, on_rollback);
> } else if (new_tuple == NULL) { /* revoke */
> assert(old_tuple);
> priv_def_create_from_tuple(&priv, old_tuple);
> priv_def_check(&priv, PRIV_REVOKE);
> - struct trigger *on_commit =
> - txn_alter_trigger_new(revoke_priv, NULL);
> - txn_on_commit(txn, on_commit);
> + priv.access = 0;
> + grant_or_revoke(&priv);
> + struct trigger *on_rollback =
> + txn_alter_trigger_new(modify_priv, old_tuple);
> + txn_on_rollback(txn, on_rollback);
> } else { /* modify */
> priv_def_create_from_tuple(&priv, new_tuple);
> priv_def_check(&priv, PRIV_GRANT);
> - struct trigger *on_commit =
> - txn_alter_trigger_new(modify_priv, NULL);
> - txn_on_commit(txn, on_commit);
> + grant_or_revoke(&priv);
> + struct trigger *on_rollback =
> + txn_alter_trigger_new(modify_priv, old_tuple);
> + txn_on_rollback(txn, on_rollback);
> }
> }
Overall, I like this change as we'll need it anyway to implement DDL
batching (i.e. transaction support for non-yielding DDL statements).
Pushed to master with some cosmetic changes:
diff --git a/src/box/alter.cc b/src/box/alter.cc
index 1b9e2238..3d44362b 100644
--- a/src/box/alter.cc
+++ b/src/box/alter.cc
@@ -3047,7 +3047,7 @@ grant_or_revoke(struct priv_def *priv)
}
}
-/** A trigger called on rollback of grant, or on commit of revoke. */
+/** A trigger called on rollback of grant. */
static void
revoke_priv(struct trigger *trigger, void *event)
{
@@ -3059,13 +3059,14 @@ revoke_priv(struct trigger *trigger, void *event)
grant_or_revoke(&priv);
}
-/** A trigger called on rollback of grant, or on commit of revoke. */
+/** A trigger called on rollback of revoke or modify. */
static void
modify_priv(struct trigger *trigger, void *event)
{
(void) event;
+ struct tuple *tuple = (struct tuple *)trigger->data;
struct priv_def priv;
- priv_def_create_from_tuple(&priv, (struct tuple *)trigger->data);
+ priv_def_create_from_tuple(&priv, tuple);
grant_or_revoke(&priv);
}
More information about the Tarantool-patches
mailing list