[tarantool-patches] Re: [PATCH 5/5] swim: expose Lua triggers on member update

[Konstantin Osipov]

* Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [19/06/03 14:33]:
> 
> Events object has methods to help a user to determine what update
> has happened.
> ```Lua
> local function on_update(member, events, ctx)
>     if events:is_new() then

This doesn't look proper English to me, events is plural, is_new()
is used for singular case. It is either an event_mask, or an event
list/set, but not something in the middle.

What about:

event_mask:has(...)?
> +    enum swim_ev_mask {
> +        SWIM_EV_NEW             = 0b00000001,
> +        SWIM_EV_NEW_STATUS      = 0b00000010,
> +        SWIM_EV_NEW_URI         = 0b00000100,
> +        SWIM_EV_NEW_INCARNATION = 0b00001000,
> +        SWIM_EV_NEW_PAYLOAD     = 0b00010000,
> +        SWIM_EV_UPDATE          = 0b00011110,
> +        SWIM_EV_DROP            = 0b00100000,
> +    };

Or simply export these objects to Lua and let users play with
them.


-- 
Konstantin Osipov, Moscow, Russia