[tarantool-patches] Re: [PATCH v2 0/9] sql: cleanup code from obsolete macros

n.pettik korablev at tarantool.org
Thu Jun 6 21:22:48 MSK 2019



> On 29 May 2019, at 17:01, Stanislav Zudin <szudin at tarantool.org> wrote:
> 
> The patch removes unused constants and macros
> The 2nd version returns back the SQL_OMIT_AUTOMATIC_INDEX and
> the code enabled by this macro.
> Removes the remains of the multithreading from the VDBE's 
> sorting tools.
> Enables output of number of scanned rows when EXPLAIN
> keyword is used. Updates the affected tests.

Generally speaking, patch-set is OK since it provides
straightforward refactoring. But I would whether squash
all these patches or change their description and group
by thematic topics (like sql: remove unused macros
connected with memory management system).
It’s up to you.





More information about the Tarantool-patches mailing list