[tarantool-patches] Re: [PATCH v4 6/9] wal: introduce a journal entry finalization callback

Konstantin Osipov kostja at tarantool.org
Thu Jun 20 10:56:46 MSK 2019


* Georgy Kirichenko <georgy at tarantool.org> [19/06/20 09:54]:
> +	if (entry->on_done_cb)
> +		entry->on_done_cb(entry, entry->on_done_cb_data);

 A single callback is enough for today perhaps, but generally this
 looks exactly like a single trigger for me.
 
 Could we perhaps allocate a journal entry right in txn_new(), and
 move txn commit/rollback trigger objects to the journal entry
 object? 

-- 
Konstantin Osipov, Moscow, Russia




More information about the Tarantool-patches mailing list