[tarantool-patches] Re: [PATCH v3 2/6] box: rework box_lua_{call, eval} to use input port

[Vladimir Davydov]

On Wed, Jun 19, 2019 at 06:51:15PM +0300, Kirill Shcherbatov wrote:
> >>  	module_gc(module);
> >> +	if (rc != 0) {
> >> +		if (diag_last_error(&fiber()->diag) == NULL) {
> >> +			/* Stored procedure forget to set diag  */
> >> +			diag_set(ClientError, ER_PROC_C, "unknown error");
> >> +		}
> >> +		port_destroy(out_port);
> >> +		return -1;
> >> +	}
> >
> >Shouldn't you call region_truncate() here to clean up after the function
> >and possibly port_get_msgpack()?
> No, the func_c_call implementation must clean region by it's own.

But you did add region_truncate() to the place I pointed to.
I'm confused...

Anyway, please resend the whole series in a separate thread rather
than bloating this one.