[PATCH v2 2/2] decimal: expose decimal type to lua.

Vladimir Davydov vdavydov.dev at gmail.com
Fri Jun 28 18:32:34 MSK 2019


The patch looks good, but you haven't covered all error cases in
the test:

  https://coveralls.io/builds/24265960/source?filename=src/lua/decimal.c

Please make sure there's no red lines.

Also, I asked you during the previous review iteration, but you seem to
have overlooked it: can we please do anything about the trailing spaces?

On Fri, Jun 28, 2019 at 05:36:39PM +0300, Serge Petrenko wrote:
> +decimal.new(ffi.new('float', 128.5))
> +---
> +- '128.500000000000000'
> +...
> +decimal.new(ffi.new('double', 128.5))
> +---
> +- '128.500000000000000'
> +...
> +decimal.new(1)
> +---
> +- '1.000000000000000'
> +...
> +decimal.new(-1)
> +---
> +- '-1.000000000000000'
> +...
> +decimal.new(2^64)
> +---
> +- '18446744073709551616.000000000000000'
> +...



More information about the Tarantool-patches mailing list