[tarantool-patches] Re: [PATCH v5 0/6] box: run checks on insertions in LUA spaces

[Vladislav Shpilevoy]

The patchset is LGTM. I've created a follow-up
issue: https://github.com/tarantool/tarantool/issues/4272

On 04/06/2019 10:21, Kirill Shcherbatov wrote:
>> Please, proceed with next patches. We need to
>> make a single Vdbe for all checks in a separate
>> commit.
>>
>> There is also a new proposal for benchmark. Lets
>> compare SQL CHECKs with tuple validation in Lua
>> before insertion, and see what is faster. Please,
>> write down somewhere all our planned benchmarks so
>> as no to forget something.
>>
>> Totally:
>> 1) bench CHECKs before your patch via pure SQL
>> 2) bench before your patch via checks done in Lua
>> before insertion
>> 3) bench after patch via pure SQL
>> 4) bench via Lua DML
>>
>> After single Vdbe is implemented, bench 3 and 4 again.
> 
> Hi! Thank you for review an fixes! They are looking appropriately. I squashed them
> and fixed commit headers where necessary.
> 
> I'll try to do what you've mention as soon as possible (don't know, what has higher
> priority - this or functional indexes fixes).
> 
> However, can we merge the patch up to this point now?
>