[tarantool-patches] Re: [PATCH v1] test: replication/misc fix for high load

[Alexander Turenko]

I'm okay.

Serge, do you have any objections?

WBR, Alexander Turenko.

On Fri, Jun 07, 2019 at 04:25:12PM +0300, Alexander V. Tikhonov wrote:
> Fixed test replication/misc to be able to run it on
> hosts under high load. Changed downstream check to
> use test_run:wait_downstream() function, to wait for
> certain box.info.replication values to fix the error:
> 
> [050] replication/misc.test.lua                                       [ fail ]
> [050]
> [050] Test failed! Result content mismatch:
> [050] --- replication/misc.result	Thu Jun  6 06:46:54 2019
> [050] +++ replication/misc.reject	Fri Jun  7 05:55:00 2019
> [050] @@ -622,7 +622,7 @@
> [050]  ...
> [050]  box.info.replication[2].downstream.status
> [050]  ---
> [050] -- stopped
> [050] +- follow
> [050]  ...
> [050]  test_run:cmd("stop server replica")
> [050]  ---
> 
> Closes #4277
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4277-test-replication-misc
> Issue: https://github.com/tarantool/tarantool/issues/4277
> 
>  test/replication/misc.result   | 4 ++--
>  test/replication/misc.test.lua | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/test/replication/misc.result b/test/replication/misc.result
> index 5d7a6512e..f896ee4a9 100644
> --- a/test/replication/misc.result
> +++ b/test/replication/misc.result
> @@ -620,9 +620,9 @@ test_run:wait_log("replica", "REPLICASET_UUID_MISMATCH", nil, 1.0)
>  ---
>  - REPLICASET_UUID_MISMATCH
>  ...
> -box.info.replication[2].downstream.status
> +test_run:wait_downstream(2, {status = 'stopped'})
>  ---
> -- stopped
> +- true
>  ...
>  test_run:cmd("stop server replica")
>  ---
> diff --git a/test/replication/misc.test.lua b/test/replication/misc.test.lua
> index 5a6cecfaa..4be12ba3b 100644
> --- a/test/replication/misc.test.lua
> +++ b/test/replication/misc.test.lua
> @@ -251,7 +251,7 @@ _ = box.space._schema:replace{'cluster', tostring(uuid.new())}
>  -- master believes replica is in cluster, but their cluster UUIDs differ.
>  test_run:cmd("start server replica")
>  test_run:wait_log("replica", "REPLICASET_UUID_MISMATCH", nil, 1.0)
> -box.info.replication[2].downstream.status
> +test_run:wait_downstream(2, {status = 'stopped'})
>  
>  test_run:cmd("stop server replica")
>  test_run:cmd("cleanup server replica")
> -- 
> 2.17.1
>