[tarantool-patches] Re: [PATCH v3 06/14] txn: get rid of fiber_gc from txn_rollback
Konstantin Osipov
kostja at tarantool.org
Sun Jun 16 19:38:25 MSK 2019
* Georgy Kirichenko <georgy at tarantool.org> [19/06/09 23:47]:
> Don't touch a fiber gc storage on a transaction rollback explicitly.
> This relaxes dependencies between fiber and transaction life cycles.
>
Generally, it's quite difficult to track what review comments
you addressed since you didn't reply to the review email :(
There is also no link to the branch :(
> Prerequisites: #1254
> ---
> src/box/applier.cc | 8 +++++---
> src/box/box.cc | 14 +++++++++-----
> src/box/call.c | 22 ++++++++++++++++------
> src/box/memtx_engine.c | 3 ++-
> src/box/txn.c | 35 +++++++++++++++++------------------
> src/box/txn.h | 8 ++++++--
> src/box/vy_scheduler.c | 10 +++++++---
> 7 files changed, 62 insertions(+), 38 deletions(-)
>
> diff --git a/src/box/applier.cc b/src/box/applier.cc
> index e3203a4c8..5a92f6109 100644
> --- a/src/box/applier.cc
> +++ b/src/box/applier.cc
> @@ -190,7 +190,7 @@ apply_initial_join_row(struct xrow_header *row)
> fiber_gc();
> return rc;
> rollback:
> - txn_rollback();
> + txn_rollback(txn);
> return -1;
> }
shouldn't there be a fiber_gc() here?
> @@ -334,7 +336,7 @@ apply_wal_row(struct xstream *stream, struct xrow_header *row)
> }
> if (box_process_rw(&request, space, NULL) != 0) {
> say_error("error applying row: %s", request_str(&request));
> - txn_rollback();
> + txn_rollback(txn);
and here?
> @@ -395,7 +401,7 @@ txn_commit(struct txn *txn)
> if (txn->n_new_rows + txn->n_applier_rows > 0) {
> txn->signature = txn_write_to_wal(txn);
> if (txn->signature < 0)
> - goto fail;
> + return -1;
> }
I still don't understand this change.
--
Konstantin Osipov, Moscow, Russia
More information about the Tarantool-patches
mailing list