[tarantool-patches] Re: [PATCH v2 5/8] Commit engine before all triggers

[Георгий Кириченко]

On Friday, May 31, 2019 10:32:12 PM MSK Konstantin Osipov wrote:
> * Georgy Kirichenko <georgy at tarantool.org> [19/05/23 11:47]:
> > ---
> > 
> >  src/box/txn.c | 14 +++++++-------
> >  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> Why do you need this change?
> 
> Since on_commit() triggers are not allowed to fail, this is
> harmless.
on_commit trigger could yield and break engine->commit order. However, I 
doesn't affect us right now (at least I don't have proofs), and this patch 
could be eliminated.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20190603/9cd691f9/attachment.sig>