[tarantool-patches] [PATCH v2 0/3] sql: clean-up in case constraint creation failed
imeevma at tarantool.org
imeevma at tarantool.org
Fri Jun 28 15:07:47 MSK 2019
This patch makes VDBE run destructors before halting in case
constraint creation failed. This is done using new opcode
OP_Error, which allows to set an error and do a jump without
halting VDBE.
https://github.com/tarantool/tarantool/issues/4183
https://github.com/tarantool/tarantool/tree/imeevma/gh-4183-clean-up-when-constraint-creation-failed
Changes in v2:
1) Opcode OP_Error was renamed to OP_SetDiag
2) Now OP_SetDiag is used for diag_set() for all VDBE errors. This
functionality has been removed from OP_Halt.
3) Fixed error with broken destructors for constraints.
Mergen Imeev (3):
sql: add OP_SetDiag opcode in VDBE
sql: clean-up in case constraint creation failed
sql: Fix destructors for constraints
src/box/sql/build.c | 115 +++++++++++++++++++++++++++-----------------
src/box/sql/expr.c | 6 ++-
src/box/sql/fk_constraint.c | 3 +-
src/box/sql/insert.c | 13 ++---
src/box/sql/select.c | 20 +++++---
src/box/sql/sqlInt.h | 2 +-
src/box/sql/trigger.c | 6 ++-
src/box/sql/vdbe.c | 53 ++++++++++----------
test/sql/checks.result | 3 +-
test/sql/checks.test.lua | 2 +-
test/sql/clear.result | 47 ++++++++++++++++++
test/sql/clear.test.lua | 20 ++++++++
12 files changed, 200 insertions(+), 90 deletions(-)
--
2.7.4
More information about the Tarantool-patches
mailing list