[tarantool-patches] Re: [PATCH 5/5] box/lua/console: Limit lua output for local sessions only

Cyrill Gorcunov gorcunov at gmail.com
Wed Jul 24 20:35:43 MSK 2019


On Wed, Jul 24, 2019 at 08:15:37PM +0300, Konstantin Osipov wrote:
> * Cyrill Gorcunov <gorcunov at gmail.com> [19/07/24 01:35]:
> > To make full support of lua mode on remote connection we
> > need pass this option to remote server. Also we need to
> > provide a compatibility layer for servers from previous
> > series and thus recode yaml output on client side.
> > 
> > This will be done in next patches, for now simply limit
> > the usage of lua output to local sessions only.
> > 
> > Part-of #3834
> > ---
> >  src/box/lua/console.lua | 30 ++++++++++++++++++++++++++++++
> >  1 file changed, 30 insertions(+)
> 
> I don't think this patch is necessary, or we need to do anything
> about remote consoles. What we have is good enough - remote format
> is used. We can simply document it.
> Whoever doesn't like the remote format, can change it right after
> connecting to the remote.
> 
> Not pushing.

I see. Need to implement deep testing of all this.




More information about the Tarantool-patches mailing list