[tarantool-patches] Re: [PATCH 5/5] sql: introduce VARBINARY column type

n.pettik korablev at tarantool.org
Wed Jul 31 17:51:18 MSK 2019



> On 30 Jul 2019, at 22:52, Vladislav Shpilevoy <v.shpilevoy at tarantool.org> wrote:
> 
> Oh, but wait. Travis is fully red:
> 
> https://travis-ci.org/tarantool/tarantool/builds/565497371?utm_source=github_status&utm_medium=notification
> 
> Looks like you forgot to update plan in sql-tap/func.test.lua.

Yep, thanks, fixed. Now gitlab seems to be OK:

https://gitlab.com/tarantool/tarantool/pipelines/73961933

> On 30/07/2019 21:41, Vladislav Shpilevoy wrote:
>> Hi! Thanks for the fixes!
>> 
>> LGTM.
>> 
>>>>>> 3. BLOB keyword is reserved, but also it is used in parse.y:980.
>>>>>> Should not it be deleted from all the rules, and be just
>>>>>> reserved?
>>>>> 
>>>>> It’s rule for declaring blob (aka binary string) literals.
>>>>> I can rename it, but TBO it looks OK to me.
>>>> 
>>>> Could you please provide an example, how to use BLOB keyword to
>>>> declare a literal? I can't find any test, using BLOB in a query
>>>> string for anything.
>>> 
>>> I meant that it’s not the rule that allows BLOB keyword but
>>> the rule to process X’…’ literals. When string is processed by
>>> lexer (tokenize.c) its token type is assigned to TK_BLOB.
>> 
>> Ahh, I got it now. BLOB(X) is not a 'BLOB' keyword, it is rather
>> like a rule 'BLOB := x...'. Then of course it is ok, nothing to
>> do here.
>> 
> 





More information about the Tarantool-patches mailing list