[tarantool-patches] Re: [PATCH 3/3] box/console: Test for nil value in args directly

Cyrill Gorcunov gorcunov at gmail.com
Mon Jul 29 00:42:01 MSK 2019


On Sun, Jul 28, 2019 at 09:47:02PM +0300, Konstantin Osipov wrote:
> * Cyrill Gorcunov <gorcunov at gmail.com> [19/07/27 01:21]:
> > Instead of allocating a variable for optional args
> > testing we should use dot notation instead. Otherwise
> > it won't work for trivial test case as
> > 
> > ```
> > require('console').set_default_output('lua,block')
> > require('decimal').new('1234.5678')
> 
> Actually, could you add a test? then lgtm :)

Yes, tests are my first priority now. I've been reading test
engine code (the process is not that fast as I thought of)
and occasionally spotted the problem. Anyway I'll rework
the series and resend together with test. Thanks for review!




More information about the Tarantool-patches mailing list