[tarantool-patches] Re: [PATCH] httpc: fix bug with segfault by wrong headers

Alexander Turenko alexander.turenko at tarantool.org
Mon Jul 29 15:25:35 MSK 2019


On Mon, Jul 29, 2019 at 01:59:25PM +0300, Kirill Yukhin wrote:
> Hello,
> 
> On 16 Jun 18:24, Roman Khabibov wrote:
> > There wasn't lua_istable() checking for field 'headers'.
> > 
> > Closes #4281
> > ---
> > 
> > Branch: https://github.com/tarantool/tarantool/compare/romanhabibov/gh-4281-header
> > Issue: https://github.com/tarantool/tarantool/issues/4281
> 
> I've checked your patch into master.

https://github.com/tarantool/tarantool/issues/3679 was pushed to 2.1 and
1.10 too (85e1d78bc6605ab189b4253867a5f72ebf356f4a,
328ec3655021fb3eaf0441998f60d6c2630f1008).
https://github.com/tarantool/tarantool/issues/4281 is the bug according
to labels and we backport bugfixes backward as I understand our process.

I think this fix should be backported to 2.1 and 1.10.

BTW, the patch fixes a memleak: it is rare (only when arguments are
incorrect), but anyway.

WBR, Alexander Turenko.




More information about the Tarantool-patches mailing list