[PATCH v2] box/memtx: Skip tuple memory from coredump by default

[Cyrill Gorcunov]

Quoting feature request

 | Tarantool is Database and Application Server in one box.
 |
 | Appserver development process contains a lot of
 | lua/luajit-ffi/lua-c-extension code.
 |
 | Coredump is very useful in case when some part of appserver crashed.
 | If the reason is input - data from database is not necessary. If the reason
 | is output - data from database is already in snap/xlog files.
 |
 | Therefore consider core dumps without data enabled by default.

For info: the strip_core feature has been introduced in
549140b390f2db3a29dbba2d44170d215f4c7700

Closes #4337

@TarantoolBot document
Title: Document box.cfg.strip_core

When Tarantool runs under a heavy load the memory allocated
for tuples may be very huge in size and to eliminate this
memory from being present in `coredump` file the `box.cfg.strip_core`
parameter should be set to `true`.

The default value is `true`.
---
v2:
 - Add documentation reference

The following changes since commit dc2e7a7b8d6559122bf7e844c62c3ee0c19b2c43:

  sql: rfc for SQL and Lua functions (2019-07-11 13:30:41 +0300)

are available in the Git repository at:

  https://github.com/cyrillos/tarantool.git strip-core

for you to fetch changes up to d06f1d6bfaff3ca269b234d17b6b29739e94aaa2:

  box/memtx: Skip tuple memory from coredump by default (2019-07-12 01:26:32 +0300)

----------------------------------------------------------------
Cyrill Gorcunov (1):
      box/memtx: Skip tuple memory from coredump by default

 src/box/lua/load_cfg.lua        | 2 +-
 test/app-tap/init_script.result | 2 +-
 test/box/admin.result           | 2 +-
 test/box/cfg.result             | 4 ++--
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/box/lua/load_cfg.lua b/src/box/lua/load_cfg.lua
index d1be0f391..83e99e854 100644
--- a/src/box/lua/load_cfg.lua
+++ b/src/box/lua/load_cfg.lua
@@ -25,7 +25,7 @@ end
 local default_cfg = {
     listen              = nil,
     memtx_memory        = 256 * 1024 *1024,
-    strip_core          = false,
+    strip_core          = true,
     memtx_min_tuple_size = 16,
     memtx_max_tuple_size = 1024 * 1024,
     slab_alloc_factor   = 1.05,
diff --git a/test/app-tap/init_script.result b/test/app-tap/init_script.result
index 16ae8a9c6..6a296d9f6 100644
--- a/test/app-tap/init_script.result
+++ b/test/app-tap/init_script.result
@@ -32,7 +32,7 @@ box.cfg
 27	replication_timeout:1
 28	rows_per_wal:500000
 29	slab_alloc_factor:1.05
-30	strip_core:false
+30	strip_core:true
 31	too_long_threshold:0.5
 32	vinyl_bloom_fpr:0.05
 33	vinyl_cache:134217728
diff --git a/test/box/admin.result b/test/box/admin.result
index bbebbd224..906e01e8d 100644
--- a/test/box/admin.result
+++ b/test/box/admin.result
@@ -85,7 +85,7 @@ cfg_filter(box.cfg)
   - - slab_alloc_factor
     - 1.05
   - - strip_core
-    - false
+    - true
   - - too_long_threshold
     - 0.5
   - - vinyl_bloom_fpr
diff --git a/test/box/cfg.result b/test/box/cfg.result
index 81f4afac8..d85ec634c 100644
--- a/test/box/cfg.result
+++ b/test/box/cfg.result
@@ -73,7 +73,7 @@ cfg_filter(box.cfg)
   - - slab_alloc_factor
     - 1.05
   - - strip_core
-    - false
+    - true
   - - too_long_threshold
     - 0.5
   - - vinyl_bloom_fpr
@@ -174,7 +174,7 @@ cfg_filter(box.cfg)
   - - slab_alloc_factor
     - 1.05
   - - strip_core
-    - false
+    - true
   - - too_long_threshold
     - 0.5
   - - vinyl_bloom_fpr
-- 
2.20.1