[PATCH v3 1/4] box: introduce key_def->is_multikey flag

Konstantin Osipov kostja at tarantool.org
Wed Jul 17 17:34:54 MSK 2019


* Kirill Shcherbatov <kshcherbatov at tarantool.org> [19/07/17 09:39]:
> Previously only key definitions that have JSON paths were able
> to define multikey index. We used to check multikey_path != NULL
> test to determine whether given key definition is multikey.
> In further patches with functional indexes this rule becomes
> outdated. Functional index extracted key definition may be
> multikey, but has no JSON paths.
> So an explicit is_multikey flag was introduced.

The patch is lgtm, but shouldn't you also rename multikey_path to
json_path?


-- 
Konstantin Osipov, Moscow, Russia



More information about the Tarantool-patches mailing list