[tarantool-patches] Re: [PATCH] httpc: fix bug with segfault by wrong headers

Alexander Turenko alexander.turenko at tarantool.org
Tue Jul 23 10:48:05 MSK 2019


> +/**
> + * Traverse headers in a Lua table and save them into 'struct
> + * httpc_request'.
> + *
> + * @param L Lua stack.
> + * @param req http request.
> + *
> + * @retval HEADERS_SUCCESS on success.
> + * @retval HEADERS_BAD_HEADERS on 'bad headers' error.
> + * @retval HEADERS_BAD_KEYS on 'bad keys' error.
> + * @retval HEADERS_INTERNAL_ERR on internal error.
> + */
> +static enum headers_status
> +fill_outgoing_headers(struct lua_State *L, int idx, struct httpc_request *req)

BTW, are we really need to extract this code into the function? As I see
the change of the question can be done w/o increasing an indent level.




More information about the Tarantool-patches mailing list