[PATCH 2/5] txn: run on_rollback triggers on txn_abort

Vladimir Davydov vdavydov.dev at gmail.com
Tue Jul 9 11:49:10 MSK 2019


On Tue, Jul 09, 2019 at 12:56:18AM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev at gmail.com> [19/07/08 22:14]:
> > On Mon, Jul 08, 2019 at 03:14:08PM +0300, Konstantin Osipov wrote:
> > > * Vladimir Davydov <vdavydov.dev at gmail.com> [19/07/08 13:02]:
> > > > > This manipulation should be in txn_abort(), not in
> > > > > txn_run_triggers(). It's txn_abort().
> > > > 
> > > > But this function is also called from completion callback, where it has
> > > > to set the txn as well. That's why I put it there, otherwise we would
> > > > have to set/restore txn context in txn_complete as well. I'm not really
> > > > against it - just pointint it out. I'll prepare a patch that does that,
> > > > see how it looks.
> > > 
> > > Yes, so, basically, txn_begin(), txn_abort(), txn_complete()
> > > should manage the fiber key.
> > 
> > Okay, please take a look at the patch below.
> 
> Much safer. Thanks. LGTM.

Pushed to master.



More information about the Tarantool-patches mailing list