[tarantool-patches] Re: [PATCH 5/6] sql: introduce extended range for INTEGER type
Vladislav Shpilevoy
v.shpilevoy at tarantool.org
Tue Jul 2 00:53:05 MSK 2019
Thanks for the fixes!
Consider new one below, and on the branch
in a separate commit.
=====================================================
diff --git a/src/box/sql/expr.c b/src/box/sql/expr.c
index fca22c371..8854fec06 100644
--- a/src/box/sql/expr.c
+++ b/src/box/sql/expr.c
@@ -3311,8 +3311,7 @@ expr_code_int(struct Parse *parse, struct Expr *expr, bool is_neg,
if (sql_atoi64(z, &value, &unused, len) != 0 ||
(is_neg && (uint64_t) value > (uint64_t) INT64_MAX + 1)) {
int_overflow:
- diag_set(ClientError, ER_INT_LITERAL_MAX, sign, z,
- INT64_MIN, UINT64_MAX);
+ diag_set(ClientError, ER_INT_LITERAL_MAX, sign, z);
parse->is_aborted = true;
return;
}
More information about the Tarantool-patches
mailing list