[tarantool-patches] Re: [PATCH v1 1/1] sql: return lookaside system

n.pettik korablev at tarantool.org
Mon Jul 15 17:42:04 MSK 2019



> On 9 Jul 2019, at 12:03, Imeev Mergen <imeevma at tarantool.org> wrote:
> 
> Hi! Thank you for review. My answer below.
> 
> On 7/8/19 4:13 PM, n.pettik wrote:
>> 
>>> On 6 Jul 2019, at 13:23, imeevma at tarantool.org wrote:
>>> 
>>> After the removal of the LOOKASIDE system, it was found that the
>>> performance dropped. To restore performance, this patch partially
>>> returns the LOOKASIDE system in almost the same form as it was
>>> before the patch 4326ca7.
>>> 
>>> Closes #4319
>> Have you verified that performance is restored by these changes?
>> 
> I asked @avtikhon to check this before sending the patch. He
> checked that the performance was restored. Should I copy here the
> tables that he sent me?

I’m ok with this patch. But just in case I would test it with asan/valgrind
(if they are still functioning with Tarantool’s test suite).



More information about the Tarantool-patches mailing list