[tarantool-patches] Re: [PATCH v3 1/4] sql: remove unnecessary AUTOINCREMENT ID generation

n.pettik korablev at tarantool.org
Mon Jul 15 20:50:36 MSK 2019


>>> src/box/sql/insert.c                    |  5 +----
>>> test/sql/gh-2981-check-autoinc.result   | 32 ++++++++++++++++++++++++++++++++
>>> test/sql/gh-2981-check-autoinc.test.lua | 11 ++++++++++-
>>> 3 files changed, 43 insertions(+), 5 deletions(-)
>>> 
>>> diff --git a/src/box/sql/insert.c b/src/box/sql/insert.c
>>> index b353148..d2b4e17 100644
>>> --- a/src/box/sql/insert.c
>>> +++ b/src/box/sql/insert.c
>>> @@ -628,10 +628,7 @@ sqlInsert(Parse * pParse,	/* Parser context */
>>> 			if (j < 0 || nColumn == 0
>>> 			    || (pColumn && j >= pColumn->nId)) {
>>> 				if (i == (int) autoinc_fieldno) {
>>> -					sqlVdbeAddOp2(v,
>>> -							  OP_NextAutoincValue,
>>> -							  space->def->id,
>>> -							  iRegStore);
>> 
>> Why didn’t you delete OP_NextAutioncValue?
>> 
> I changed it functionality in the next patch.

You changes affect more than 50% of opcode's content.
Please, to make patches well structured, remove opcode
in current patch and resurrect in the next one.





More information about the Tarantool-patches mailing list