[tarantool-patches] [PATCH 1/1] test: fix flaky swim/errinj.test.lua

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Tue Jul 30 22:34:35 MSK 2019


In one place that test sends a packet and expects that it has
arrived two lines below. Under high load it may take more time.
The patch makes the test explicitly wait for the packet arrival.

Closes #4392
---
Issue: https://github.com/tarantool/tarantool/issues/4392
Branch: https://github.com/tarantool/tarantool/tree/gerold103/gh-4392-swim-flaky-test

 test/swim/errinj.result   | 3 +++
 test/swim/errinj.test.lua | 1 +
 2 files changed, 4 insertions(+)

diff --git a/test/swim/errinj.result b/test/swim/errinj.result
index efeab87a8..cf26b0a4a 100644
--- a/test/swim/errinj.result
+++ b/test/swim/errinj.result
@@ -60,6 +60,9 @@ errinj.set("ERRINJ_SWIM_FD_ONLY", false)
 ---
 - ok
 ...
+while s1_view:incarnation().version ~= 2 do fiber.sleep(0.01) end
+---
+...
 s1_view:payload()
 ---
 - null
diff --git a/test/swim/errinj.test.lua b/test/swim/errinj.test.lua
index cf0cb2dd4..6c73f9f3d 100644
--- a/test/swim/errinj.test.lua
+++ b/test/swim/errinj.test.lua
@@ -26,6 +26,7 @@ s1:self():incarnation()
 errinj.set("ERRINJ_SWIM_FD_ONLY", true)
 s1:probe_member(s2:self():uri())
 errinj.set("ERRINJ_SWIM_FD_ONLY", false)
+while s1_view:incarnation().version ~= 2 do fiber.sleep(0.01) end
 s1_view:payload()
 s1_view:incarnation()
 
-- 
2.20.1 (Apple Git-117)





More information about the Tarantool-patches mailing list