[PATCH v4 4/4] box: introduce functional indexes

[Konstantin Osipov]

* Kirill Shcherbatov <kshcherbatov at tarantool.org> [19/07/24 10:38]:

I think generally you're on track, and patch needs a careful
review now. Please solicit a review from Vova. For the
tuple_compare part, please ask Vlad to take a look - he did a lot
in this part of the code.

The only issue that surprised me is that you allocate a separate
tuple chunk for each key. I somehow thought that you're going to
use the same chunk for all bps tree entries, which I now realize
is impossible, since you'll need to store a chunk offset somewhere.
The problem is that slab alloc doesn't have a slab for tiny chunks
now - the smallest chunk is 24 bytes. 
This is obviously an overkill for this scenario. Please fix the
slab arena accordingly.

There are lots of style comments, I'll place them on the branch.


-- 
Konstantin Osipov, Moscow, Russia