[tarantool-patches] [PATCH v2 0/3] sql: do not show IDs generated by trigger

imeevma at tarantool.org imeevma at tarantool.org
Thu Jul 4 14:42:07 MSK 2019


Currently, if an INSERT was executed by a trigger during the
execution of a statement, if there were any generated identifiers,
they can be displayed as a result of the statement. This is
incorrect, since we are not able to divide the IDs obtained into
those that belong to the table mentioned in the statement and
those that do not belong to this table.

https://github.com/tarantool/tarantool/issues/4188
https://github.com/tarantool/tarantool/tree/imeevma/gh-4188-remove-additonal-generated-ids

Changes in v2:
1) Patch was divided into 3 new patches.

Mergen Imeev (3):
  sql: remove unnecessary AUTOINCREMENT ID generation
  sql: do not show IDs generated by trigger
  sql: remove VDBE from TXN

 src/box/errcode.h                       |  1 +
 src/box/sequence.c                      | 22 +++++++++----
 src/box/sequence.h                      | 13 ++++++--
 src/box/sql/insert.c                    | 15 ++++++---
 src/box/sql/parse.y                     |  4 +--
 src/box/sql/sqlInt.h                    |  2 +-
 src/box/sql/trigger.c                   | 12 +++----
 src/box/sql/vdbe.c                      | 25 ++++++++-------
 src/box/sql/vdbe.h                      |  3 +-
 src/box/sql/vdbeInt.h                   |  2 +-
 src/box/sql/vdbeaux.c                   | 10 +++---
 src/box/txn.h                           | 17 ----------
 test/box/misc.result                    |  1 +
 test/sql/gh-2981-check-autoinc.result   | 32 ++++++++++++++++++
 test/sql/gh-2981-check-autoinc.test.lua | 11 ++++++-
 test/sql/iproto.result                  |  2 --
 test/sql/triggers.result                | 57 +++++++++++++++++++++++++++++++++
 test/sql/triggers.test.lua              | 14 ++++++++
 18 files changed, 177 insertions(+), 66 deletions(-)

-- 
2.7.4





More information about the Tarantool-patches mailing list