[tarantool-patches] Re: [PATCH 1/2] sql: extend struct Mem with field_type member

[Konstantin Osipov]

* Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [19/07/28 21:49]:
> >  	const char *z = 0;
> >  	UNUSED_PARAMETER(NotUsed);
> > +	enum field_type f_t = argv[0]->field_type;
> 
> 1. Perhaps, field_type is not the best name, because Mem is not always
> is a field. It can be just a value, not from a space. It is rather
> just 'type'.
> 

I think field_type is good because it's clear it's derived from
enum field_type. Mem has more than one type now, so just "type" is
ambiguous. My 0.02

-- 
Konstantin Osipov, Moscow, Russia