[tarantool-patches] [PATCH v3 0/3] sql: clean-up in case constraint creation failed
imeevma at tarantool.org
imeevma at tarantool.org
Thu Jul 4 13:49:36 MSK 2019
This patch makes VDBE run destructors before halting in case
constraint creation failed. This is done using new opcode
OP_SetDiag, which allows to set an error and do a jump without
halting VDBE.
https://github.com/tarantool/tarantool/issues/4183
https://github.com/tarantool/tarantool/tree/imeevma/gh-4183-clean-up-when-constraint-creation-failed
Changes in v3:
1) Removed unnecessary changes.
2) Fixed commit-messages.
3) Now OP_Halt won't be added after OP_SetDiag in case clean-up
needed.
Mergen Imeev (3):
sql: add OP_SetDiag opcode in VDBE
sql: clean-up in case constraint creation failed
sql: use common registers instead of temp. for constraints data
src/box/sql/build.c | 117 ++++++++++++++++++++++++++++----------------
src/box/sql/expr.c | 6 ++-
src/box/sql/fk_constraint.c | 3 +-
src/box/sql/insert.c | 11 +++--
src/box/sql/select.c | 14 ++++--
src/box/sql/sqlInt.h | 2 +-
src/box/sql/trigger.c | 6 ++-
src/box/sql/vdbe.c | 31 +++++++-----
test/sql/checks.result | 3 +-
test/sql/checks.test.lua | 2 +-
test/sql/clear.result | 50 +++++++++++++++++++
test/sql/clear.test.lua | 23 +++++++++
12 files changed, 196 insertions(+), 72 deletions(-)
--
2.7.4
More information about the Tarantool-patches
mailing list